<html>
<head><meta charset="utf-8"><title>triagebot pendings · t-compiler/wg-prioritization · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/index.html">t-compiler/wg-prioritization</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html">triagebot pendings</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="197572991"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197572991" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197572991">(May 14 2020 at 15:33)</a>:</h4>
<p>yesterday I was commenting <span class="user-mention" data-user-id="255061">@LeSeulArtichaut</span> that would be great to fire prioritization when we add <code>regression-from-stable-to-beta</code> and <code>regression-from-stable-to-nightly</code> labels to issues</p>



<a name="197573108"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197573108" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197573108">(May 14 2020 at 15:34)</a>:</h4>
<p>we ended also talking that prioritization was fired twice when someone runs the command because it also add the label and that re-fires the thing</p>



<a name="197573165"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197573165" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197573165">(May 14 2020 at 15:34)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> what code is executed when a github label is added?</p>



<a name="197573192"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197573192" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197573192">(May 14 2020 at 15:34)</a>:</h4>
<p>not sure what you're asking</p>



<a name="197573209"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197573209" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197573209">(May 14 2020 at 15:34)</a>:</h4>
<p>like, a lot of code? :)</p>



<a name="197573214"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197573214" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197573214">(May 14 2020 at 15:35)</a>:</h4>
<p>I'm not sure how things are connected here, does Github fires a post to us somewhere?</p>



<a name="197573222"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197573222" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197573222">(May 14 2020 at 15:35)</a>:</h4>
<p>yeah</p>



<a name="197573247"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197573247" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197573247">(May 14 2020 at 15:35)</a>:</h4>
<p>where does that land?</p>



<a name="197573248"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197573248" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197573248">(May 14 2020 at 15:35)</a>:</h4>
<p>triagebot will get a webhook post</p>



<a name="197573258"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197573258" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197573258">(May 14 2020 at 15:35)</a>:</h4>
<p>in triagebot?</p>



<a name="197573263"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197573263" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197573263">(May 14 2020 at 15:35)</a>:</h4>
<p>ok</p>



<a name="197573267"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197573267" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197573267">(May 14 2020 at 15:35)</a>:</h4>
<p>I looked at the code earlier</p>



<a name="197573302"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197573302" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197573302">(May 14 2020 at 15:35)</a>:</h4>
<p>We fire the prioritize command when the <code>I-prioritize</code> label is added</p>



<a name="197573339"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197573339" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197573339">(May 14 2020 at 15:35)</a>:</h4>
<p>Which means, as the prioritize command adds the label, the command is fired twice</p>



<a name="197573420"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197573420" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197573420">(May 14 2020 at 15:36)</a>:</h4>
<p>yep</p>



<a name="197573548"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197573548" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197573548">(May 14 2020 at 15:36)</a>:</h4>
<p>One solution is to not create the Zulip thread/message when <code>@rustbot prioritize</code> is used, and delay it when the label is added</p>



<a name="197573673"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197573673" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197573673">(May 14 2020 at 15:37)</a>:</h4>
<p>we should be able to ignore the label if it's added by the bot</p>



<a name="197573767"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197573767" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197573767">(May 14 2020 at 15:38)</a>:</h4>
<p>Oh right, we recieve it along with the webhook event</p>



<a name="197573779"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197573779" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197573779">(May 14 2020 at 15:38)</a>:</h4>
<p>can't we make the prioritization process start only when the label is added?</p>



<a name="197573792"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197573792" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197573792">(May 14 2020 at 15:38)</a>:</h4>
<p>and make the command just add that label</p>



<a name="197573799"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197573799" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197573799">(May 14 2020 at 15:38)</a>:</h4>
<p>The problem is</p>



<a name="197573867"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197573867" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197573867">(May 14 2020 at 15:39)</a>:</h4>
<p>If we ignore when the bot adds the label, then we won't create the Zulip post when people use the <code>@rustbot modify labels</code> command</p>



<a name="197573909"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197573909" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197573909">(May 14 2020 at 15:39)</a>:</h4>
<p>yeah seems fine to just trigger zulip on the label and not the command</p>



<a name="197573918"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197573918" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197573918">(May 14 2020 at 15:39)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116266">Santiago Pastorino</span> <a href="#narrow/stream/227806-t-compiler.2Fwg-prioritization/topic/triagebot.20pendings/near/197573779">said</a>:</p>
<blockquote>
<p>can't we make the prioritization process start only when the label is added?</p>
</blockquote>
<p>That's what I proposed</p>



<a name="197573950"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197573950" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197573950">(May 14 2020 at 15:40)</a>:</h4>
<p>Alright I can do that then</p>



<a name="197573998"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197573998" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197573998">(May 14 2020 at 15:40)</a>:</h4>
<p><em>Quickly</em></p>



<a name="197574089"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197574089" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197574089">(May 14 2020 at 15:40)</a>:</h4>
<p><span aria-label="+1" class="emoji emoji-1f44d" role="img" title="+1">:+1:</span></p>



<a name="197574106"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197574106" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197574106">(May 14 2020 at 15:41)</a>:</h4>
<p>I was wondering also ...</p>



<a name="197574122"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197574122" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197574122">(May 14 2020 at 15:41)</a>:</h4>
<div class="codehilite"><pre><span></span><code><span class="k">if</span><span class="w"> </span><span class="kd">let</span><span class="w"> </span><span class="nb">Some</span><span class="p">(</span><span class="n">Token</span>::<span class="n">Word</span><span class="p">(</span><span class="s">&quot;prioritize&quot;</span><span class="p">))</span><span class="w"> </span><span class="o">=</span><span class="w"> </span><span class="n">input</span><span class="p">.</span><span class="n">peek_token</span><span class="p">()</span><span class="o">?</span><span class="w"> </span><span class="p">{</span><span class="w"></span>
</code></pre></div>



<a name="197574167"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197574167" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197574167">(May 14 2020 at 15:41)</a>:</h4>
<p>are we checking that the label contains <code>prioritize</code>?</p>



<a name="197574187"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197574187" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197574187">(May 14 2020 at 15:41)</a>:</h4>
<p>That's for the command I guess</p>



<a name="197574206"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197574206" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197574206">(May 14 2020 at 15:41)</a>:</h4>
<p>that's the parser, not the label</p>



<a name="197574209"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197574209" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197574209">(May 14 2020 at 15:41)</a>:</h4>
<p>I just naively run <code>rg "I-prioritize"</code> and didn't find anything</p>



<a name="197574218"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197574218" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197574218">(May 14 2020 at 15:41)</a>:</h4>
<p>The <code>@rustbot prioritize</code> command, I mean</p>



<a name="197574242"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197574242" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197574242">(May 14 2020 at 15:41)</a>:</h4>
<p>ahh right</p>



<a name="197574276"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197574276" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197574276">(May 14 2020 at 15:42)</a>:</h4>
<p>The label is stored in <code>triagebot.toml</code> file</p>



<a name="197574286"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197574286" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197574286">(May 14 2020 at 15:42)</a>:</h4>
<p>the label is configured in triagebot.toml in rust-lang/rust</p>



<a name="197574305"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197574305" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197574305">(May 14 2020 at 15:42)</a>:</h4>
<p>On the repo</p>



<a name="197574331"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197574331" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197574331">(May 14 2020 at 15:42)</a>:</h4>
<p>ohh I see</p>



<a name="197574418"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197574418" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197574418">(May 14 2020 at 15:42)</a>:</h4>
<p>So if we want to prioritize when certain labels are added we should do that in the <code>triagebot.toml</code> too, right?</p>



<a name="197574470"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197574470" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197574470">(May 14 2020 at 15:43)</a>:</h4>
<p>I guess we may want something like</p>



<a name="197574485"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197574485" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197574485">(May 14 2020 at 15:43)</a>:</h4>
<p>We could have a <code>prioritize-on</code> field for example</p>



<a name="197574569"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197574569" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197574569">(May 14 2020 at 15:43)</a>:</h4>
<div class="codehilite"><pre><span></span><code>[prioritize]
label = [&quot;I-prioritize&quot;, &quot;regression-from-stable-to-beta&quot;, &quot;regression-from-stable-to-nightly&quot;]
zulip_stream = 227806
</code></pre></div>



<a name="197574586"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197574586" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197574586">(May 14 2020 at 15:43)</a>:</h4>
<p>maybe?</p>



<a name="197574670"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197574670" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197574670">(May 14 2020 at 15:44)</a>:</h4>
<p>instead of what we have which is ...</p>



<a name="197574682"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197574682" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197574682">(May 14 2020 at 15:44)</a>:</h4>
<p>The <code>label</code> field here is the label we assign when we use the prioritize command</p>



<a name="197574713"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197574713" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197574713">(May 14 2020 at 15:44)</a>:</h4>
<p>ahh :)</p>



<a name="197574723"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197574723" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197574723">(May 14 2020 at 15:44)</a>:</h4>
<p>And also the label the bot reacts to when added to create the Zulip topic</p>



<a name="197574747"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197574747" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197574747">(May 14 2020 at 15:44)</a>:</h4>
<p>We can have a separate list of course</p>



<a name="197574779"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197574779" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197574779">(May 14 2020 at 15:45)</a>:</h4>
<p>yeah then what you've said, prioritize-on</p>



<a name="197574815"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197574815" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197574815">(May 14 2020 at 15:45)</a>:</h4>
<p>What would you prefer? Adding <code>I-prioritize</code> when regression are found?</p>



<a name="197574848"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197574848" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197574848">(May 14 2020 at 15:45)</a>:</h4>
<p>Or sending a message without adding <code>I-prioritize</code>?</p>



<a name="197574885"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197574885" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197574885">(May 14 2020 at 15:46)</a>:</h4>
<p>it's the same</p>



<a name="197574947"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197574947" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197574947">(May 14 2020 at 15:46)</a>:</h4>
<p>maybe better and easier to add <code>I-prioritize</code></p>



<a name="197574966"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197574966" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197574966">(May 14 2020 at 15:46)</a>:</h4>
<p>Personally I prefer the first solution, because it shows that we have a discussion running</p>



<a name="197575001"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197575001" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197575001">(May 14 2020 at 15:46)</a>:</h4>
<p>And when we're done then we can remove it</p>



<a name="197575003"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197575003" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197575003">(May 14 2020 at 15:46)</a>:</h4>
<p>yeah, agree, let's add <code>I-prioritize</code></p>



<a name="197575026"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197575026" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197575026">(May 14 2020 at 15:46)</a>:</h4>
<p>definitely</p>



<a name="197575045"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197575045" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197575045">(May 14 2020 at 15:46)</a>:</h4>
<p>are you doing this or should I?</p>



<a name="197575060"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197575060" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197575060">(May 14 2020 at 15:47)</a>:</h4>
<p>I don't know</p>



<a name="197575073"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197575073" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197575073">(May 14 2020 at 15:47)</a>:</h4>
<p>I'll be fixing the bug with the command first I think</p>



<a name="197575092"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197575092" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197575092">(May 14 2020 at 15:47)</a>:</h4>
<p><span aria-label="+1" class="emoji emoji-1f44d" role="img" title="+1">:+1:</span></p>



<a name="197575100"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197575100" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197575100">(May 14 2020 at 15:47)</a>:</h4>
<p>Because then we'll have a clean code for implementing that new feature</p>



<a name="197575131"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197575131" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197575131">(May 14 2020 at 15:47)</a>:</h4>
<p>ok, let me know when you finish</p>



<a name="197575193"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197575193" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197575193">(May 14 2020 at 15:48)</a>:</h4>
<p>I'll send a link to the PR as soon as I'm done</p>



<a name="197575203"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197575203" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197575203">(May 14 2020 at 15:48)</a>:</h4>
<p><span aria-label="+1" class="emoji emoji-1f44d" role="img" title="+1">:+1:</span>, great, thanks</p>



<a name="197575208"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197575208" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197575208">(May 14 2020 at 15:48)</a>:</h4>
<p>I'll also ping <span class="user-mention silent" data-user-id="116122">simulacrum</span> <span aria-label="innocent" class="emoji emoji-1f607" role="img" title="innocent">:innocent:</span></p>



<a name="197575537"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197575537" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197575537">(May 14 2020 at 15:50)</a>:</h4>
<p>:)</p>



<a name="197576068"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197576068" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197576068">(May 14 2020 at 15:54)</a>:</h4>
<div class="codehilite"><pre><span></span><code>[santiago@galago triagebot (master)]$ git diff
diff --git a/src/handlers/relabel.rs b/src/handlers/relabel.rs
index 9a889a5..e6c8a56 100644
--- a/src/handlers/relabel.rs
+++ b/src/handlers/relabel.rs
@@ -105,6 +105,15 @@ async fn handle_input(
                     issue_labels.push(github::Label {
                         name: label.to_string(),
                     });
+                    if label.as_str() == &quot;regression-from-stable-to-beta&quot;
+                        || label.as_str() == &quot;regression-from-stable-to-nightly&quot;
+                    {
+                        if !issue_labels.iter().any(|l| l.name == &quot;I-prioritize&quot;) {
+                            issue_labels.push(github::Label {
+                                name: &quot;I-prioritize&quot;.to_string(),
+                            });
+                        }
+                    }
                 }
             }
             LabelDelta::Remove(label) =&gt; {
</code></pre></div>



<a name="197576072"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197576072" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197576072">(May 14 2020 at 15:54)</a>:</h4>
<p>done</p>



<a name="197576085"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197576085" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197576085">(May 14 2020 at 15:54)</a>:</h4>
<p><span aria-label="joy" class="emoji emoji-1f602" role="img" title="joy">:joy:</span></p>



<a name="197576123"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197576123" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197576123">(May 14 2020 at 15:54)</a>:</h4>
<p>:D</p>



<a name="197576243"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197576243" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197576243">(May 14 2020 at 15:55)</a>:</h4>
<p>No, no, that's not right</p>



<a name="197576261"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197576261" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197576261">(May 14 2020 at 15:55)</a>:</h4>
<p>we don't want that as part of relabeling</p>



<a name="197576296"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197576296" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197576296">(May 14 2020 at 15:55)</a>:</h4>
<p>because you want it to happen when someone adds the label through github ui</p>



<a name="197576316"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197576316" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197576316">(May 14 2020 at 15:55)</a>:</h4>
<p>so you'll want to do it in the prioritization handler</p>



<a name="197576456"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197576456" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197576456">(May 14 2020 at 15:56)</a>:</h4>
<p><em>Also it's the first time I use rust-analyser outside of rustc</em></p>



<a name="197576478"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197576478" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197576478">(May 14 2020 at 15:56)</a>:</h4>
<p><em>It's amazing</em> <span aria-label="eyes" class="emoji emoji-1f440" role="img" title="eyes">:eyes:</span></p>



<a name="197576526"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197576526" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197576526">(May 14 2020 at 15:57)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116122">simulacrum</span> <a href="#narrow/stream/227806-t-compiler.2Fwg-prioritization/topic/triagebot.20pendings/near/197576296">said</a>:</p>
<blockquote>
<p>because you want it to happen when someone adds the label through github ui</p>
</blockquote>
<p>maybe I got wrong what relabel is</p>



<a name="197576550"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197576550" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197576550">(May 14 2020 at 15:57)</a>:</h4>
<p>but yeah, we want to do it once any of those labels are added</p>



<a name="197576563"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197576563" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197576563">(May 14 2020 at 15:57)</a>:</h4>
<p>not only through github ui</p>



<a name="197576574"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197576574" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197576574">(May 14 2020 at 15:57)</a>:</h4>
<p>Look at src/handlers/prioritize.rs line 34 xD</p>



<a name="197576619"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197576619" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197576619">(May 14 2020 at 15:57)</a>:</h4>
<p>Currently we have:</p>
<div class="codehilite"><pre><span></span><code><span class="w">                    </span><span class="k">if</span><span class="w"> </span><span class="n">e</span><span class="p">.</span><span class="n">label</span><span class="p">.</span><span class="n">as_ref</span><span class="p">().</span><span class="n">expect</span><span class="p">(</span><span class="s">&quot;label&quot;</span><span class="p">).</span><span class="n">name</span><span class="w"> </span><span class="o">==</span><span class="w"> </span><span class="n">config</span><span class="p">.</span><span class="n">label</span><span class="w"> </span><span class="p">{</span><span class="w"></span>
<span class="w">                        </span><span class="c1">// We need to take the exact same action in this case.</span>
<span class="w">                        </span><span class="k">return</span><span class="w"> </span><span class="nb">Ok</span><span class="p">(</span><span class="nb">Some</span><span class="p">(</span><span class="n">Prioritize</span>::<span class="n">Start</span><span class="p">));</span><span class="w"></span>
<span class="w">                    </span><span class="p">}</span><span class="w"></span>
</code></pre></div>



<a name="197576624"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197576624" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197576624">(May 14 2020 at 15:58)</a>:</h4>
<p><span aria-label="+1" class="emoji emoji-1f44d" role="img" title="+1">:+1:</span></p>



<a name="197576675"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197576675" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197576675">(May 14 2020 at 15:58)</a>:</h4>
<p>I was kind of kidding and playing a bit</p>



<a name="197576688"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197576688" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197576688">(May 14 2020 at 15:58)</a>:</h4>
<p>but maybe I should just implement this :)</p>



<a name="197576723"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197576723" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197576723">(May 14 2020 at 15:58)</a>:</h4>
<p>So IIUC we fire a prioritize command if the label matches the label in the config</p>



<a name="197576765"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197576765" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197576765">(May 14 2020 at 15:58)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116266">Santiago Pastorino</span> <a href="#narrow/stream/227806-t-compiler.2Fwg-prioritization/topic/triagebot.20pendings/near/197576675">said</a>:</p>
<blockquote>
<p>I was kind of kidding and playing a bit</p>
</blockquote>
<p>Don't worry I got it <span aria-label="laughing" class="emoji emoji-1f606" role="img" title="laughing">:laughing:</span></p>



<a name="197576839"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197576839" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197576839">(May 14 2020 at 15:59)</a>:</h4>
<p>anyway kidding about hard coding the things</p>



<a name="197576846"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197576846" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197576846">(May 14 2020 at 15:59)</a>:</h4>
<p>but now that I see prioritize handler it's more clear</p>



<a name="197576861"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197576861" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197576861">(May 14 2020 at 15:59)</a>:</h4>
<p><span aria-label="+1" class="emoji emoji-1f44d" role="img" title="+1">:+1:</span></p>



<a name="197577719"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197577719" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197577719">(May 14 2020 at 16:05)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/issues/72200">#72200</a></p>



<a name="197577788"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197577788" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197577788">(May 14 2020 at 16:05)</a>:</h4>
<p><em>Damn you're quick</em> x)</p>



<a name="197577884"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197577884" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197577884">(May 14 2020 at 16:06)</a>:</h4>
<p>Not sure we want to include <code>I-prioritize</code> in the list though</p>



<a name="197577936"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197577936" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197577936">(May 14 2020 at 16:06)</a>:</h4>
<p>Because the behaviour will be to add <code>I-prioritize</code> whenever those are added</p>



<a name="197577963"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197577963" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197577963">(May 14 2020 at 16:06)</a>:</h4>
<p><span class="user-mention" data-user-id="116266">@Santiago Pastorino</span></p>



<a name="197578014"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197578014" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197578014">(May 14 2020 at 16:07)</a>:</h4>
<p>you're right</p>



<a name="197578066"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197578066" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197578066">(May 14 2020 at 16:07)</a>:</h4>
<p>maybe with this idea the name is not great</p>



<a name="197578085"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197578085" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197578085">(May 14 2020 at 16:07)</a>:</h4>
<p>also_prioritize_on</p>



<a name="197578103"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197578103" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197578103">(May 14 2020 at 16:07)</a>:</h4>
<p>well it's fine as is I guess :)</p>



<a name="197578107"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197578107" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197578107">(May 14 2020 at 16:07)</a>:</h4>
<p>I also think so</p>



<a name="197578208"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197578208" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197578208">(May 14 2020 at 16:08)</a>:</h4>
<p>When I threw it I was about to say <em>please send help for a better name</em></p>



<a name="197578319"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197578319" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197578319">(May 14 2020 at 16:08)</a>:</h4>
<p>but I think it's ok</p>



<a name="197578343"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197578343" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197578343">(May 14 2020 at 16:09)</a>:</h4>
<p>because clearly <code>I-prioritize</code> is a request for prioritization</p>



<a name="197578368"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197578368" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197578368">(May 14 2020 at 16:09)</a>:</h4>
<p>fixed the PR</p>



<a name="197578377"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197578377" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197578377">(May 14 2020 at 16:09)</a>:</h4>
<p><span aria-label="+1" class="emoji emoji-1f44d" role="img" title="+1">:+1:</span></p>



<a name="197578385"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197578385" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197578385">(May 14 2020 at 16:09)</a>:</h4>
<p>polishing a bit the other part</p>



<a name="197578864"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197578864" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197578864">(May 14 2020 at 16:12)</a>:</h4>
<p>I think it's just</p>



<a name="197578869"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197578869" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197578869">(May 14 2020 at 16:12)</a>:</h4>
<div class="codehilite"><pre><span></span><code>diff --git a/src/config.rs b/src/config.rs
index 0c6f5f2..550dff0 100644
--- a/src/config.rs
+++ b/src/config.rs
@@ -78,6 +78,7 @@ pub(crate) struct RelabelConfig {
 #[derive(PartialEq, Eq, Debug, serde::Deserialize)]
 pub(crate) struct PrioritizeConfig {
     pub(crate) label: String,
+    pub(crate) prioritize_on: Vec&lt;String&gt;,
     pub(crate) zulip_stream: u64,
 }

diff --git a/src/handlers/prioritize.rs b/src/handlers/prioritize.rs
index f965422..21a735b 100644
--- a/src/handlers/prioritize.rs
+++ b/src/handlers/prioritize.rs
@@ -34,7 +34,11 @@ impl Handler for PrioritizeHandler {
         if let Event::Issue(e) = event {
             if e.action == github::IssuesAction::Labeled {
                 if let Some(config) = config {
-                    if e.label.as_ref().expect(&quot;label&quot;).name == config.label {
+                    if config
+                        .prioritize_on
+                        .iter()
+                        .any(|l| l == &amp;e.label.as_ref().expect(&quot;label&quot;).name)
+                    {
                         // We need to take the exact same action in this case.
                         return Ok(Some(Prioritize::Start));
                     }
</code></pre></div>



<a name="197578900"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197578900" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197578900">(May 14 2020 at 16:12)</a>:</h4>
<p>we don't want to do anything when the label is removed</p>



<a name="197578967"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197578967" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197578967">(May 14 2020 at 16:13)</a>:</h4>
<p>to remove the request from prioritization is removing <code>I-prioritize</code>, nothing should happen if regression related labels are removed</p>



<a name="197579381"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197579381" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197579381">(May 14 2020 at 16:15)</a>:</h4>
<p>opened too <a href="https://github.com/rust-lang/triagebot/issues/542">triagebot#542</a></p>



<a name="197580084"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197580084" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197580084">(May 14 2020 at 16:20)</a>:</h4>
<blockquote>
<p>Hm, probably stable-to-stable too?</p>
</blockquote>
<p>Do we want to prioritize on stable regressions</p>



<a name="197580114"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197580114" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197580114">(May 14 2020 at 16:20)</a>:</h4>
<p>I also think we should</p>



<a name="197580167"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197580167" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197580167">(May 14 2020 at 16:20)</a>:</h4>
<p>commented, I think we should yeah</p>



<a name="197580182"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197580182" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197580182">(May 14 2020 at 16:21)</a>:</h4>
<p>there are 22 unprioritized regressions right now</p>



<a name="197580183"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197580183" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197580183">(May 14 2020 at 16:21)</a>:</h4>
<p>Oh also <span class="user-mention" data-user-id="116266">@Santiago Pastorino</span>, should we prioritize even if the issue is already prioritized?</p>



<a name="197580327"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197580327" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197580327">(May 14 2020 at 16:22)</a>:</h4>
<p>you're right, we should not request prioritization if it's <code>P-*</code> already</p>



<a name="197580368"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197580368" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197580368">(May 14 2020 at 16:22)</a>:</h4>
<p>So maybe add (another) field in config</p>



<a name="197580381"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197580381" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197580381">(May 14 2020 at 16:22)</a>:</h4>
<p>hehe <span aria-label="+1" class="emoji emoji-1f44d" role="img" title="+1">:+1:</span></p>



<a name="197580387"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197580387" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197580387">(May 14 2020 at 16:22)</a>:</h4>
<p>To describe what a priority is</p>



<a name="197580411"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197580411" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197580411">(May 14 2020 at 16:22)</a>:</h4>
<p>I guess we can reuse code from the relabel command</p>



<a name="197580471"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197580471" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197580471">(May 14 2020 at 16:23)</a>:</h4>
<p>Which accepted those blob patterns (not sure what there're called)</p>



<a name="197580533"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197580533" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197580533">(May 14 2020 at 16:23)</a>:</h4>
<p><span class="user-mention silent" data-user-id="255061">LeSeulArtichaut</span> <a href="#narrow/stream/227806-t-compiler.2Fwg-prioritization/topic/triagebot.20pendings/near/197580411">said</a>:</p>
<blockquote>
<p>I guess we can reuse code from the relabel command</p>
</blockquote>
<p>what do you mean?</p>



<a name="197580638"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197580638" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197580638">(May 14 2020 at 16:24)</a>:</h4>
<p>In the configuration for the relabel command, triagebot accepts those patterns</p>



<a name="197580653"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197580653" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197580653">(May 14 2020 at 16:24)</a>:</h4>
<p>also added a new attribute to <a href="https://github.com/rust-lang/rust/issues/72200">#72200</a></p>



<a name="197580656"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197580656" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197580656">(May 14 2020 at 16:24)</a>:</h4>
<p>So you should be able to reuse code from there</p>



<a name="197580768"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197580768" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197580768">(May 14 2020 at 16:25)</a>:</h4>
<p>Having <code>P-*</code> in the config would be more convenient</p>



<a name="197580784"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197580784" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197580784">(May 14 2020 at 16:25)</a>:</h4>
<p>But that's a detail anyway :P</p>



<a name="197580851"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197580851" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197580851">(May 14 2020 at 16:25)</a>:</h4>
<p>so yeah, I thought about that but I was worried a bit that we may have <code>P-something-not-priority</code></p>



<a name="197580881"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197580881" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197580881">(May 14 2020 at 16:25)</a>:</h4>
<p>at some point I thought we were going to call <code>I-prioritize</code> <code>P-prioritize</code></p>



<a name="197580943"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197580943" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197580943">(May 14 2020 at 16:26)</a>:</h4>
<p>but yeah, what I'm saying probably doesn't make sense</p>



<a name="197580944"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197580944" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197580944">(May 14 2020 at 16:26)</a>:</h4>
<p>:)</p>



<a name="197580953"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197580953" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197580953">(May 14 2020 at 16:26)</a>:</h4>
<p>will do a pattern</p>



<a name="197580998"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197580998" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197580998">(May 14 2020 at 16:26)</a>:</h4>
<p>Right, we might no have the <code>P-</code> prefix monopoly forever :D</p>



<a name="197581103"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197581103" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197581103">(May 14 2020 at 16:27)</a>:</h4>
<p>pushed with the pattern</p>



<a name="197581115"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197581115" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197581115">(May 14 2020 at 16:27)</a>:</h4>
<p><code>priorities_pattern = "P-*"</code></p>



<a name="197581165"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197581165" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197581165">(May 14 2020 at 16:27)</a>:</h4>
<p>will fix triagebot code after lunch</p>



<a name="197581427"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197581427" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197581427">(May 14 2020 at 16:29)</a>:</h4>
<p>Fun fact: if you type <code>@spastorino</code> on GitHub the UI suggests you <code>@rust-lang/cargo-taggers</code> <span aria-label="big smile" class="emoji emoji-1f604" role="img" title="big smile">:big_smile:</span></p>



<a name="197582266"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197582266" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197582266">(May 14 2020 at 16:35)</a>:</h4>
<p>Opened <a href="https://github.com/rust-lang/triagebot/issues/543">triagebot#543</a></p>



<a name="197582428"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197582428" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197582428">(May 14 2020 at 16:36)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> Do you have time to review this one? It should hopefully be pretty quick <span aria-label="big smile" class="emoji emoji-1f604" role="img" title="big smile">:big_smile:</span></p>



<a name="197584983"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197584983" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197584983">(May 14 2020 at 16:55)</a>:</h4>
<p>yeah I can take a look</p>



<a name="197585003"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197585003" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197585003">(May 14 2020 at 16:55)</a>:</h4>
<p>Thanks <span aria-label="+1" class="emoji emoji-1f44d" role="img" title="+1">:+1:</span></p>



<a name="197586367"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197586367" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197586367">(May 14 2020 at 17:04)</a>:</h4>
<p><span class="user-mention silent" data-user-id="255061">LeSeulArtichaut</span> <a href="#narrow/stream/227806-t-compiler.2Fwg-prioritization/topic/triagebot.20pendings/near/197581427">said</a>:</p>
<blockquote>
<p>Fun fact: if you type <code>@spastorino</code> on GitHub the UI suggests you <code>@rust-lang/cargo-taggers</code> <span aria-label="big smile" class="emoji emoji-1f604" role="img" title="big smile">:big_smile:</span></p>
</blockquote>
<p>WAT?</p>



<a name="197586375"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197586375" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197586375">(May 14 2020 at 17:04)</a>:</h4>
<p>hahahaha</p>



<a name="197586416"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197586416" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197586416">(May 14 2020 at 17:04)</a>:</h4>
<p><span aria-label="shrug" class="emoji emoji-1f937" role="img" title="shrug">:shrug:</span></p>



<a name="197586464"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197586464" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197586464">(May 14 2020 at 17:04)</a>:</h4>
<p><em>Is that a coincidence? I don't think so...</em> <span aria-label="eyes" class="emoji emoji-1f440" role="img" title="eyes">:eyes:</span></p>



<a name="197587394"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197587394" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197587394">(May 14 2020 at 17:10)</a>:</h4>
<p><a href="https://github.com/rust-lang/triagebot/issues/543">triagebot#543</a> just landed (thanks again <span class="user-mention" data-user-id="116122">@simulacrum</span>!)<br>
<span class="user-mention" data-user-id="116266">@Santiago Pastorino</span> I think you'll want to rebase your PR onto master now. To make triagebot add the <code>I-prioritize</code> label, you'll now want to return <code>Prioritize::Label</code> instead of <code>Prioritize::Start</code>.</p>



<a name="197588542"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197588542" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197588542">(May 14 2020 at 17:19)</a>:</h4>
<p>yeah, just got back</p>



<a name="197588558"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197588558" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197588558">(May 14 2020 at 17:19)</a>:</h4>
<p>done and force pushed with the proper fixes</p>



<a name="197588731"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197588731" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197588731">(May 14 2020 at 17:20)</a>:</h4>
<p>ahh let me mark the fields with serde(default)</p>



<a name="197588848"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197588848" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197588848">(May 14 2020 at 17:21)</a>:</h4>
<p>ok, done</p>



<a name="197588926"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197588926" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197588926">(May 14 2020 at 17:22)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/issues/72200">#72200</a> and <a href="https://github.com/rust-lang/triagebot/issues/542">triagebot#542</a> should be both ready</p>



<a name="197591540"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197591540" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197591540">(May 14 2020 at 17:42)</a>:</h4>
<p>hold on what I did is wrong</p>



<a name="197591546"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197591546" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197591546">(May 14 2020 at 17:42)</a>:</h4>
<p>wasn't paying attention</p>



<a name="197591556"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197591556" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197591556">(May 14 2020 at 17:42)</a>:</h4>
<p><span aria-label="innocent" class="emoji emoji-1f607" role="img" title="innocent">:innocent:</span></p>



<a name="197591898"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197591898" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197591898">(May 14 2020 at 17:45)</a>:</h4>
<p>By the way if someone has to prioritize an issue, I would be grateful if someone tests using <code>@rustbot prioritize</code></p>



<a name="197592505"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197592505" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197592505">(May 14 2020 at 17:50)</a>:</h4>
<p><span aria-label="+1" class="emoji emoji-1f44d" role="img" title="+1">:+1:</span></p>



<a name="197592514"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197592514" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197592514">(May 14 2020 at 17:50)</a>:</h4>
<p>pushed</p>



<a name="197592516"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197592516" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197592516">(May 14 2020 at 17:50)</a>:</h4>
<p>now yes</p>



<a name="197592538"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197592538" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197592538">(May 14 2020 at 17:50)</a>:</h4>
<p>"should" be ready</p>



<a name="197592716"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197592716" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197592716">(May 14 2020 at 17:51)</a>:</h4>
<p><span class="user-mention" data-user-id="255061">@LeSeulArtichaut</span> about <a href="https://github.com/rust-lang/triagebot/pull/542/files#r425313569">https://github.com/rust-lang/triagebot/pull/542/files#r425313569</a>, I like your name better but do you think would be better using a <code>Vec&lt;String&gt;</code> here?</p>



<a name="197592779"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197592779" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197592779">(May 14 2020 at 17:52)</a>:</h4>
<p>I guess we won't have really complex patterns to find labels</p>



<a name="197592781"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197592781" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197592781">(May 14 2020 at 17:52)</a>:</h4>
<p>I think it would be consistent with the relabel command</p>



<a name="197592802"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197592802" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197592802">(May 14 2020 at 17:52)</a>:</h4>
<p>That's a nitpick, really</p>



<a name="197592836"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197592836" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197592836">(May 14 2020 at 17:52)</a>:</h4>
<p>yeah but I'm not even reusing the code because it's just using glob in my case</p>



<a name="197593105"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197593105" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197593105">(May 14 2020 at 17:54)</a>:</h4>
<p>renamed it</p>



<a name="197593171"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197593171" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197593171">(May 14 2020 at 17:54)</a>:</h4>
<p>However I still think the logic is wrong...</p>



<a name="197593264"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197593264" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197593264">(May 14 2020 at 17:55)</a>:</h4>
<p>We still need to have this part of the code:</p>
<div class="codehilite"><pre><span></span><code><span class="k">if</span><span class="w"> </span><span class="n">e</span><span class="p">.</span><span class="n">label</span><span class="p">.</span><span class="n">as_ref</span><span class="p">().</span><span class="n">expect</span><span class="p">(</span><span class="s">&quot;label&quot;</span><span class="p">).</span><span class="n">name</span><span class="w"> </span><span class="o">==</span><span class="w"> </span><span class="n">config</span><span class="p">.</span><span class="n">label</span><span class="w"> </span><span class="p">{</span><span class="w"></span>
<span class="w">    </span><span class="c1">// We need to take the exact same action in this case.</span>
<span class="w">     </span><span class="k">return</span><span class="w"> </span><span class="nb">Ok</span><span class="p">(</span><span class="nb">Some</span><span class="p">(</span><span class="n">Prioritize</span>::<span class="n">Start</span><span class="p">));</span><span class="w"></span>
<span class="p">}</span><span class="w"></span>
</code></pre></div>


<p>Because I rely on it to start the Zulip thread</p>



<a name="197593539"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197593539" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197593539">(May 14 2020 at 17:56)</a>:</h4>
<p>I think we want to keep it, and append your code</p>



<a name="197594038"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197594038" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197594038">(May 14 2020 at 18:00)</a>:</h4>
<p>Also return <code>Prioritize::Label</code> in this case</p>



<a name="197594193"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197594193" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197594193">(May 14 2020 at 18:01)</a>:</h4>
<p>Oh, I amended my commit to add documentation to the variants of <code>Prioritize</code> but I didn't push it <span aria-label="face palm" class="emoji emoji-1f926" role="img" title="face palm">:face_palm:</span></p>



<a name="197594737"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197594737" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197594737">(May 14 2020 at 18:05)</a>:</h4>
<p><span class="user-mention" data-user-id="255061">@LeSeulArtichaut</span> it should be ok now</p>



<a name="197594901"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197594901" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197594901">(May 14 2020 at 18:06)</a>:</h4>
<p>Just a last question: why do we need to call <code>.to_owned()</code> on the issue labels if we only iterate through them?</p>



<a name="197595058"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197595058" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197595058">(May 14 2020 at 18:07)</a>:</h4>
<p>because it's wrong :)</p>



<a name="197595070"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197595070" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197595070">(May 14 2020 at 18:07)</a>:</h4>
<p>was copy + paste</p>



<a name="197595133"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197595133" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197595133">(May 14 2020 at 18:08)</a>:</h4>
<p><em>I can't blame you, we all do the same</em> <span aria-label="innocent" class="emoji emoji-1f607" role="img" title="innocent">:innocent:</span></p>



<a name="197596179"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197596179" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197596179">(May 14 2020 at 18:16)</a>:</h4>
<p>last thing</p>



<a name="197596185"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197596185" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197596185">(May 14 2020 at 18:16)</a>:</h4>
<p>going to change this</p>



<a name="197596193"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197596193" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197596193">(May 14 2020 at 18:16)</a>:</h4>
<div class="codehilite"><pre><span></span><code>-                            if !issue_labels.iter().any(|l| glob.matches(&amp;l.name))
+                            if issue_labels.iter().all(|l| !glob.matches(&amp;l.name))
</code></pre></div>



<a name="197596197"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197596197" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197596197">(May 14 2020 at 18:16)</a>:</h4>
<p>:P</p>



<a name="197596239"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197596239" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197596239">(May 14 2020 at 18:16)</a>:</h4>
<p>!any seems silly</p>



<a name="197613473"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197613473" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197613473">(May 14 2020 at 20:29)</a>:</h4>
<p><span aria-label="heart" class="emoji emoji-2764" role="img" title="heart">:heart:</span>  <a href="https://github.com/rust-lang/rust/pull/71891">https://github.com/rust-lang/rust/pull/71891</a></p>



<a name="197613986"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197613986" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197613986">(May 14 2020 at 20:33)</a>:</h4>
<p>^ realised that it's actually not exactly the same <span aria-label="shrug" class="emoji emoji-1f937" role="img" title="shrug">:shrug:</span></p>



<a name="197617577"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197617577" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197617577">(May 14 2020 at 21:01)</a>:</h4>
<p>oh wow</p>



<a name="197617581"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197617581" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197617581">(May 14 2020 at 21:01)</a>:</h4>
<div class="codehilite"><pre><span></span><code><span class="k">if</span><span class="w"> </span><span class="o">!</span><span class="n">associated_types</span><span class="p">.</span><span class="n">values</span><span class="p">().</span><span class="n">any</span><span class="p">(</span><span class="o">|</span><span class="n">v</span><span class="o">|</span><span class="w"> </span><span class="o">!</span><span class="n">v</span><span class="p">.</span><span class="n">is_empty</span><span class="p">())</span><span class="w"> </span><span class="p">{</span><span class="w"></span>
</code></pre></div>



<a name="197617586"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197617586" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197617586">(May 14 2020 at 21:01)</a>:</h4>
<p>:S</p>



<a name="197617735"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/197617735" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#197617735">(May 14 2020 at 21:02)</a>:</h4>
<p>it's like triple negation :)</p>



<a name="198209902"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198209902" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198209902">(May 20 2020 at 14:53)</a>:</h4>
<p><span class="user-mention" data-user-id="255061">@LeSeulArtichaut</span> <span class="user-mention" data-user-id="116122">@simulacrum</span> thoughts about this ...</p>



<a name="198209954"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198209954" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198209954">(May 20 2020 at 14:54)</a>:</h4>
<div class="codehilite"><pre><span></span><code>diff --git a/src/config.rs b/src/config.rs
index cf73536..f4a91ee 100644
--- a/src/config.rs
+++ b/src/config.rs
@@ -82,6 +82,8 @@ pub(crate) struct PrioritizeConfig {
     pub(crate) prioritize_on: Vec&lt;String&gt;,
     #[serde(default)]
     pub(crate) priority_labels: String,
+    #[serde(default)]
+    pub(crate) exclude_labels: Vec&lt;String&gt;,
     pub(crate) zulip_stream: u64,
 }

diff --git a/src/handlers/prioritize.rs b/src/handlers/prioritize.rs
index 389c41b..74b3832 100644
--- a/src/handlers/prioritize.rs
+++ b/src/handlers/prioritize.rs
@@ -44,8 +44,13 @@ impl Handler for PrioritizeHandler {
                                 let issue_labels = event.issue().unwrap().labels();
                                 let label_name = &amp;e.label.as_ref().expect(&quot;label&quot;).name;

-                                if issue_labels.iter().all(|l| !glob.matches(&amp;l.name))
-                                    &amp;&amp; config.prioritize_on.iter().any(|l| l == label_name)
+                                if issue_labels.iter().all(|l| {
+                                    !glob.matches(&amp;l.name)
+                                        &amp;&amp; config
+                                            .exclude_labels
+                                            .iter()
+                                            .all(|label_name| *label_name != l.name)
+                                }) &amp;&amp; config.prioritize_on.iter().any(|l| l == label_name)
                                 {
                                     return Ok(Some(Prioritize::Label));
                                 }
</code></pre></div>



<a name="198209965"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198209965" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198209965">(May 20 2020 at 14:54)</a>:</h4>
<p>this and ...</p>



<a name="198209989"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198209989" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198209989">(May 20 2020 at 14:54)</a>:</h4>
<p>I don't have time right this moment to read and understand diffs I'm afraid</p>



<a name="198210004"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198210004" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198210004">(May 20 2020 at 14:54)</a>:</h4>
<div class="codehilite"><pre><span></span><code>diff --git a/triagebot.toml b/triagebot.toml
index 2210a8ff8e6..1ee2aefef3f 100644
--- a/triagebot.toml
+++ b/triagebot.toml
@@ -38,4 +38,5 @@ label = &quot;ICEBreaker-Cleanup-Crew&quot;
 label = &quot;I-prioritize&quot;
 prioritize_on = [&quot;regression-from-stable-to-stable&quot;, &quot;regression-from-stable-to-beta&quot;, &quot;regression-from-stable-to-nightly&quot;]
 priority_labels = &quot;P-*&quot;
+exclude_labels = [&quot;T-infra&quot;, &quot;T-release&quot;, &quot;T-rustdoc&quot;]
 zulip_stream = 227806
</code></pre></div>



<a name="198210061"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198210061" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198210061">(May 20 2020 at 14:54)</a>:</h4>
<p>The TOML format seems good</p>



<a name="198210075"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198210075" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198210075">(May 20 2020 at 14:55)</a>:</h4>
<p>Reading the logic...</p>



<a name="198210084"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198210084" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198210084">(May 20 2020 at 14:55)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> short summary is ... on regressions skip if the issue is labelled with ["T-infra", "T-release", "T-rustdoc"]</p>



<a name="198210154"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198210154" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198210154">(May 20 2020 at 14:55)</a>:</h4>
<p>if you agree with the idea I just send a PR and we can all check the diff there at some point async</p>



<a name="198210193"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198210193" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198210193">(May 20 2020 at 14:55)</a>:</h4>
<p>hm I guess, though in practice I think we currently do rely on compiler pings to some extent</p>



<a name="198210207"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198210207" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198210207">(May 20 2020 at 14:55)</a>:</h4>
<p>but seems fine</p>



<a name="198210226"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198210226" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198210226">(May 20 2020 at 14:55)</a>:</h4>
<p><span class="user-mention" data-user-id="116266">@Santiago Pastorino</span> I think we should merge the priorities and  exclude labels</p>



<a name="198210301"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198210301" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198210301">(May 20 2020 at 14:56)</a>:</h4>
<p>into a pattern</p>



<a name="198210332"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198210332" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198210332">(May 20 2020 at 14:56)</a>:</h4>
<p>yeah, makes sense I guess :)</p>



<a name="198210333"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198210333" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198210333">(May 20 2020 at 14:56)</a>:</h4>
<p>A list of pattern I'd say</p>



<a name="198210347"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198210347" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198210347">(May 20 2020 at 14:56)</a>:</h4>
<p>yep</p>



<a name="198210417"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198210417" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198210417">(May 20 2020 at 14:57)</a>:</h4>
<p>So you'd have:</p>
<div class="codehilite"><pre><span></span><code><span class="n">exclude_labels</span> <span class="o">=</span> <span class="k">[&quot;P-*&quot;, &quot;T-infra&quot;, &quot;T-release&quot;, &quot;T-rustdoc&quot;]</span>
</code></pre></div>



<a name="198210428"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198210428" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198210428">(May 20 2020 at 14:57)</a>:</h4>
<p>Which IMO is cleaner :D</p>



<a name="198210479"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198210479" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198210479">(May 20 2020 at 14:57)</a>:</h4>
<p>Also I think we'll need to update the documentation for the feature</p>



<a name="198210489"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198210489" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198210489">(May 20 2020 at 14:57)</a>:</h4>
<p>In the triagebot wiki</p>



<a name="198210511"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198210511" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198210511">(May 20 2020 at 14:57)</a>:</h4>
<p>But that's a nit <span aria-label="slight smile" class="emoji emoji-1f642" role="img" title="slight smile">:slight_smile:</span></p>



<a name="198210807"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198210807" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198210807">(May 20 2020 at 14:59)</a>:</h4>
<p>yeah agreed</p>



<a name="198210830"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198210830" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198210830">(May 20 2020 at 14:59)</a>:</h4>
<p>I've done exactly that</p>



<a name="198210838"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198210838" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198210838">(May 20 2020 at 14:59)</a>:</h4>
<p><span aria-label="+1" class="emoji emoji-1f44d" role="img" title="+1">:+1:</span></p>



<a name="198210917"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198210917" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198210917">(May 20 2020 at 15:00)</a>:</h4>
<p>was trying to see if you both would notice this to take a short cut <span aria-label="joy" class="emoji emoji-1f602" role="img" title="joy">:joy:</span></p>



<a name="198210966"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198210966" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198210966">(May 20 2020 at 15:00)</a>:</h4>
<p>So this was a test? xD</p>



<a name="198210993"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198210993" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198210993">(May 20 2020 at 15:00)</a>:</h4>
<p>:P</p>



<a name="198211011"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198211011" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198211011">(May 20 2020 at 15:00)</a>:</h4>
<p>kidding kidding :)</p>



<a name="198213426"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198213426" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198213426">(May 20 2020 at 15:17)</a>:</h4>
<p>sending PRs</p>



<a name="198213438"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198213438" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198213438">(May 20 2020 at 15:17)</a>:</h4>
<p>first <a href="https://github.com/rust-lang/rust/issues/72385">#72385</a></p>



<a name="198213887"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198213887" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198213887">(May 20 2020 at 15:19)</a>:</h4>
<p>and</p>



<a name="198213920"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198213920" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198213920">(May 20 2020 at 15:20)</a>:</h4>
<p><a href="https://github.com/rust-lang/triagebot/issues/561">triagebot#561</a></p>



<a name="198214072"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198214072" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198214072">(May 20 2020 at 15:21)</a>:</h4>
<p>Let's <del>make you rewrite everything</del> review your code :D</p>



<a name="198214125"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198214125" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198214125">(May 20 2020 at 15:21)</a>:</h4>
<p>well I'm already changing a conditional which is doing repeated work :)</p>



<a name="198214475"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198214475" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198214475">(May 20 2020 at 15:23)</a>:</h4>
<p>pushed and well we may prefer to extract some methods there</p>



<a name="198214705"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198214705" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198214705">(May 20 2020 at 15:25)</a>:</h4>
<div class="codehilite"><pre><span></span><code><span class="p">.</span><span class="n">all</span><span class="p">(</span><span class="o">|</span><span class="n">l</span><span class="o">|</span><span class="w"> </span><span class="o">!</span><span class="n">glob</span><span class="p">.</span><span class="n">matches</span><span class="p">(</span><span class="o">&amp;</span><span class="n">l</span><span class="p">.</span><span class="n">name</span><span class="p">))</span><span class="w"></span>
</code></pre></div>


<p>Again? x)</p>



<a name="198214793"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198214793" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198214793">(May 20 2020 at 15:25)</a>:</h4>
<p>lol</p>



<a name="198214834"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198214834" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198214834">(May 20 2020 at 15:26)</a>:</h4>
<p>well to me the problem is any</p>



<a name="198214885"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198214885" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198214885">(May 20 2020 at 15:26)</a>:</h4>
<p>that means all are different</p>



<a name="198214927"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198214927" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198214927">(May 20 2020 at 15:26)</a>:</h4>
<p>that would be !any</p>



<a name="198214969"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198214969" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198214969">(May 20 2020 at 15:26)</a>:</h4>
<p>I think I prefer all(not(something) than not(any(something))</p>



<a name="198215018"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198215018" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198215018">(May 20 2020 at 15:27)</a>:</h4>
<p>the problem to me is using not(any(not(something))) or stuff like that</p>



<a name="198215076"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198215076" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198215076">(May 20 2020 at 15:27)</a>:</h4>
<p>I'm not the one maintaining the codebase, I'll leave reviewing the code quality to <span class="user-mention silent" data-user-id="116122">simulacrum</span> <span aria-label="innocent" class="emoji emoji-1f607" role="img" title="innocent">:innocent:</span></p>



<a name="198215100"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198215100" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198215100">(May 20 2020 at 15:27)</a>:</h4>
<p>my rule is kind of use any if it's straight, anyway this case may be better done with just 2 loops</p>



<a name="198215112"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198215112" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198215112">(May 20 2020 at 15:27)</a>:</h4>
<p>let me do it that way</p>



<a name="198215245"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198215245" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198215245">(May 20 2020 at 15:28)</a>:</h4>
<p>Well I think we should always write code so it sounds good to us humans, right?</p>



<a name="198215323"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198215323" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198215323">(May 20 2020 at 15:28)</a>:</h4>
<p>Anyway</p>



<a name="198216248"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198216248" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198216248">(May 20 2020 at 15:35)</a>:</h4>
<div class="codehilite"><pre><span></span><code><span class="w">                        </span><span class="k">if</span><span class="w"> </span><span class="n">config</span><span class="p">.</span><span class="n">prioritize_on</span><span class="p">.</span><span class="n">iter</span><span class="p">().</span><span class="n">any</span><span class="p">(</span><span class="o">|</span><span class="n">l</span><span class="o">|</span><span class="w"> </span><span class="n">l</span><span class="w"> </span><span class="o">==</span><span class="w"> </span><span class="n">label_name</span><span class="p">)</span><span class="w"> </span><span class="p">{</span><span class="w"></span>
<span class="w">                            </span><span class="kd">let</span><span class="w"> </span><span class="k">mut</span><span class="w"> </span><span class="n">prioritize</span><span class="w"> </span><span class="o">=</span><span class="w"> </span><span class="kc">false</span><span class="p">;</span><span class="w"></span>

<span class="w">                            </span><span class="k">for</span><span class="w"> </span><span class="n">label</span><span class="w"> </span><span class="k">in</span><span class="w"> </span><span class="n">event</span><span class="p">.</span><span class="n">issue</span><span class="p">().</span><span class="n">unwrap</span><span class="p">().</span><span class="n">labels</span><span class="p">()</span><span class="w"> </span><span class="p">{</span><span class="w"></span>
<span class="w">                                </span><span class="k">for</span><span class="w"> </span><span class="n">exclude_label</span><span class="w"> </span><span class="k">in</span><span class="w"> </span><span class="o">&amp;</span><span class="n">config</span><span class="p">.</span><span class="n">exclude_labels</span><span class="w"> </span><span class="p">{</span><span class="w"></span>
<span class="w">                                    </span><span class="k">match</span><span class="w"> </span><span class="n">glob</span>::<span class="n">Pattern</span>::<span class="n">new</span><span class="p">(</span><span class="n">exclude_label</span><span class="p">)</span><span class="w"> </span><span class="p">{</span><span class="w"></span>
<span class="w">                                        </span><span class="nb">Ok</span><span class="p">(</span><span class="n">exclude_glob</span><span class="p">)</span><span class="w"> </span><span class="o">=&gt;</span><span class="w"> </span><span class="p">{</span><span class="w"></span>
<span class="w">                                            </span><span class="n">prioritize</span><span class="w"> </span><span class="o">=</span><span class="w"> </span><span class="o">!</span><span class="n">exclude_glob</span><span class="p">.</span><span class="n">matches</span><span class="p">(</span><span class="o">&amp;</span><span class="n">label</span><span class="p">.</span><span class="n">name</span><span class="p">);</span><span class="w"></span>
<span class="w">                                        </span><span class="p">}</span><span class="w"></span>
<span class="w">                                        </span><span class="nb">Err</span><span class="p">(</span><span class="n">error</span><span class="p">)</span><span class="w"> </span><span class="o">=&gt;</span><span class="w"> </span><span class="p">{</span><span class="w"></span>
<span class="w">                                            </span><span class="n">log</span>::<span class="n">error</span><span class="o">!</span><span class="p">(</span><span class="s">&quot;Invalid glob pattern: {}&quot;</span><span class="p">,</span><span class="w"> </span><span class="n">error</span><span class="p">);</span><span class="w"></span>
<span class="w">                                        </span><span class="p">}</span><span class="w"></span>
<span class="w">                                    </span><span class="p">}</span><span class="w"></span>

<span class="w">                                    </span><span class="k">if</span><span class="w"> </span><span class="o">!</span><span class="n">prioritize</span><span class="w"> </span><span class="p">{</span><span class="w"></span>
<span class="w">                                        </span><span class="k">break</span><span class="p">;</span><span class="w"></span>
<span class="w">                                    </span><span class="p">}</span><span class="w"></span>
<span class="w">                                </span><span class="p">}</span><span class="w"></span>
<span class="w">                            </span><span class="p">}</span><span class="w"></span>

<span class="w">                            </span><span class="k">if</span><span class="w"> </span><span class="n">prioritize</span><span class="w"> </span><span class="p">{</span><span class="w"></span>
<span class="w">                                </span><span class="k">return</span><span class="w"> </span><span class="nb">Ok</span><span class="p">(</span><span class="nb">Some</span><span class="p">(</span><span class="n">Prioritize</span>::<span class="n">Label</span><span class="p">));</span><span class="w"></span>
<span class="w">                            </span><span class="p">}</span><span class="w"></span>
<span class="w">                        </span><span class="p">}</span><span class="w"></span>
</code></pre></div>


<div class="codehilite"><pre><span></span><code>
</code></pre></div>



<a name="198216275"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198216275" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198216275">(May 20 2020 at 15:35)</a>:</h4>
<p>that more imperative way may be easier to read</p>



<a name="198220032"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198220032" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198220032">(May 20 2020 at 16:03)</a>:</h4>
<p>Either that or leaving comments (you know, those lines with <code>//</code> <span aria-label="laughing" class="emoji emoji-1f606" role="img" title="laughing">:laughing:</span>)<br>
EDIT: or both? x)</p>



<a name="198225158"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198225158" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198225158">(May 20 2020 at 16:42)</a>:</h4>
<p>adding comments is for the weak <span aria-label="joy" class="emoji emoji-1f602" role="img" title="joy">:joy:</span>, I hope <span class="user-mention silent" data-user-id="116009">nikomatsakis</span> is not reading this <span aria-label="slight smile" class="emoji emoji-1f642" role="img" title="slight smile">:slight_smile:</span></p>



<a name="198225206"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198225206" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198225206">(May 20 2020 at 16:43)</a>:</h4>
<p>srsly, agree :)</p>



<a name="198225271"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198225271" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198225271">(May 20 2020 at 16:43)</a>:</h4>
<blockquote>
<p>just make the code self explanatory</p>
</blockquote>



<a name="198225358"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198225358" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198225358">(May 20 2020 at 16:44)</a>:</h4>
<p><span class="user-mention" data-user-id="216206">@lcnr</span> :), well this code is not particularly hard</p>



<a name="198225505"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198225505" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198225505">(May 20 2020 at 16:45)</a>:</h4>
<p>I can extract a function <code>needs_prioritization</code> or something and would be way more readable but I'm not sure if all this is worth investing a lot of time :)</p>



<a name="198225610"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198225610" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198225610">(May 20 2020 at 16:46)</a>:</h4>
<p><span aria-label="laughing" class="emoji emoji-1f606" role="img" title="laughing">:laughing:</span> Not saying it's needed here</p>



<a name="198227451"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198227451" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198227451">(May 20 2020 at 17:01)</a>:</h4>
<p>:)</p>



<a name="198227866"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198227866" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198227866">(May 20 2020 at 17:04)</a>:</h4>
<p>added a comment anyway</p>



<a name="198234485"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/triagebot%20pendings/near/198234485" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/triagebot.20pendings.html#198234485">(May 20 2020 at 17:57)</a>:</h4>
<p>Hey <code>@nikomatsakis</code>, please check 8 comments above x)</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>